Readme updates #59
Merged
Readme updates #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It not working on JDK21 would be due to JDK21 only being supported by newer Scala versions. |
|
Understandable. It would be really nice if sbt could require a particular version be used but it doesn't seem simple. As an aside, my language server keeps warning me that Scala 3.1.1 is deprecated, migrating to 3.3.1 (the current LTS release) doesn't seem trivial but should be doable, should I try get that working at some point? |
|
Yes, it would be sensible to migrate to a LTS release of Scala. Looking at the changes, it doesn't seem like migration would be too difficult - some things have been deprecated but only give warnings, and they would be possible to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the readme install/setup details and removes old
run_*.shscripts, to reflect changed cli args.We also got feedback that the tool doesn't work on jdk21