Skip to content

Commit

Permalink
fix ci for aslp_server. however...
Browse files Browse the repository at this point in the history
the parent aslp repository seems to be aware of the child project
when executing `dune install`.
this leads to problems like

    $ dune install
    Error: The following <package>.install are missing:
    - _build/default/aslp_server/aslp_server.install
    Hint: try running 'dune build [-p <pkg>] @install'

running the suggested `dune build -p aslp_server @install`
will fail because asli is not installed yet.

so you have to

    dune build
    dune install -p asli
    dune build -p aslp_server @install
    dune install -p aslp_server

which is a bit uncomfortable
  • Loading branch information
katrinafyi committed Dec 16, 2024
1 parent 9e25cfd commit 4c96689
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/opam.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@ jobs:

- run: opam install . --deps-only --with-test
working-directory: aslp_server
- run: opam exec -- dune build aslp_server --profile release
- run: opam exec -- dune build --profile release
working-directory: aslp_server

2 changes: 1 addition & 1 deletion aslp_server/aslp_server.opam
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ doc: "https://github.com/UQ-PAC/aslp"
bug-reports: "https://github.com/UQ-PAC/aslp/issues"
depends: [
"ocaml"
"dune" {>= "3.16"}
"dune" {>= "2.8"}
"cohttp-lwt-unix"
"yojson"
"asli"
Expand Down
1 change: 1 addition & 0 deletions aslp_server/bin/dune
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
(executable
(public_name aslp_server)
(modes exe byte)
(name main)
(modules main)
(libraries asli.libASL lwt.unix yojson cohttp-lwt cohttp-lwt-unix pprint))
Expand Down
2 changes: 1 addition & 1 deletion aslp_server/dune-project
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
(lang dune 3.16)
(lang dune 2.8)

(name aslp_server)

Expand Down
Empty file added aslp_server/dune-workspace
Empty file.

0 comments on commit 4c96689

Please sign in to comment.