Series of Minor Fixes #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Central config for a notion of operation purity * Introduce additional checks for purity in RemoveUnused
Somehow got added to the code base, should just be zdiv_int.
CSE performs some aggressive code motion, as it moves commoned expressions up to the start of the code snippet. To simplify reasoning, limit it to cases for which code motion is trivial.
ncough
force-pushed
the
minor_fixes
branch
4 times, most recently
from
07d99d3 to
6619937
Compare
Calls without bodies are left in the partial eval result. This is a little unexpected, leading to offline issues. Also fix some sanity tests to handle failure consistently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable SVE in the default lifter configtakeanddroputilitiessdiv_intEDIT: SVE opens a whole can of worms for the offline lifters. Will need to handle this later.