remove pcre library, use ocaml str instead #93

katrinafyi · 2024-06-20T06:26:44Z

PCRE relies on a shared library, precluding its use in Javascript. in this change, we use the standard ocaml "str" library instead. note, however, that this supports a smaller subscript of regex (notably no negative lookahead), and has a different syntax.

see:

aslp/tests/coverage/dune

Lines 19 to 26 in 75cf86f

    
           (rule (with-stdout-to cov_integer (run ./run "aarch64_integer.+"))) 
        
           (rule (with-stdout-to cov_branch  (run ./run "aarch64_branch.+"))) 
        
           (rule (with-stdout-to cov_float   (run ./run "aarch64_float_.+"))) 
        
           (rule (with-stdout-to cov_vector1 (run ./run "aarch64_vector_arithmetic_binary.+"))) 
        
           (rule (with-stdout-to cov_vector2 (run ./run "aarch64_vector_\\(arithmetic_unary\\|[^a]\\).+"))) 
        
           (rule (with-stdout-to cov_memory  (run ./run "aarch64_memory_.+"))) 
        
           ; note: cov_vector2 is intended to be every vector instruction that's not arithmetic_binary. 
        
           ; note ocaml Str regex syntax: https://ocaml.org/manual/5.2/api/Str.html

https://ocaml.org/manual/5.2/api/Str.html

PCRE relies on a shared library, precluding its use in Javascript. instead, we use the standard ocaml "str" library. note, however, that this supports a smaller subscript of regex (notably no negative lookahead), and has a different syntax. https://ocaml.org/manual/5.2/api/Str.html

PCRE relies on a shared library, precluding its use in Javascript. instead, we use the standard ocaml "str" library. note, however, that this supports a smaller subscript of regex (notably no negative lookahead), and has a different syntax. see: https://ocaml.org/manual/5.2/api/Str.html

* Split libASL and isolate Z3 into virtual library (#91) Z3 links to a native shared library, and so is unsuitable for use via js-of-ocaml. This separates the one use of Z3 in the code (the type-checker's constraint solver) into a separate library which may be stubbed for non-native platforms. This separates libASL into two parts: libASL_ast which is the minimum needed to define the ASL syntax tree, and libASL which contains the rest of the library. libASL should still be used as the public interface of the library. Since libASL re-exports all of libASL_ast, this should not affect the API visible by downstream users. This is required since we need to insert a platform-specific library, libASL_support, which introduces z3 only on native builds. The dependency tree now looks like: libASL_ast <- libASL_support (virtual) <- libASL. * remove pcre library, use ocaml str instead (#93) PCRE relies on a shared library, precluding its use in Javascript. instead, we use the standard ocaml "str" library. note, however, that this supports a smaller subscript of regex (notably no negative lookahead), and has a different syntax. see: https://ocaml.org/manual/5.2/api/Str.html * Embed ARM ASL specs within OCaml (#92) * extract arm environment into separate file. * allow loading files from either disk or memory * use ppx_blob to embed ASL files instead of dune-site This is instead of installing the ASL files to disk. This should make the installation less liable to random breakages when installed or linked in an unexpected way. The binary size increases by 6MB. Updates tests/coverage/run.sh to substitute away the new file paths of the embedded files, so no coverage re-generation needed. * replace --aarch64-dir with --export-aarch64 this is more useful once the MRA files are bundled. * initialising jsoo * tcheck: make global env0 mutable necessary for correct unmarshalling, as this must contain global variables * dummy libASL to reduce conflicts * rename libASL parts to stage0/stage1

katrinafyi mentioned this pull request Jun 20, 2024

Support compilation to Javascript #90

Merged

7 tasks

katrinafyi changed the base branch from partial_eval to js-of-ocaml June 24, 2024 01:02

katrinafyi force-pushed the no-pcre branch from 75cf86f to 03d0e0f Compare June 24, 2024 01:11

katrinafyi merged commit 7baee8a into js-of-ocaml Jun 24, 2024
2 checks passed

katrinafyi deleted the no-pcre branch June 26, 2024 03:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove pcre library, use ocaml str instead #93

remove pcre library, use ocaml str instead #93

katrinafyi commented Jun 20, 2024 •

edited

Loading

	(rule (with-stdout-to cov_integer (run ./run "aarch64_integer.+")))
	(rule (with-stdout-to cov_branch (run ./run "aarch64_branch.+")))
	(rule (with-stdout-to cov_float (run ./run "aarch64_float_.+")))
	(rule (with-stdout-to cov_vector1 (run ./run "aarch64_vector_arithmetic_binary.+")))
	(rule (with-stdout-to cov_vector2 (run ./run "aarch64_vector_\\(arithmetic_unary\\\|[^a]\\).+")))
	(rule (with-stdout-to cov_memory (run ./run "aarch64_memory_.+")))
	; note: cov_vector2 is intended to be every vector instruction that's not arithmetic_binary.
	; note ocaml Str regex syntax: https://ocaml.org/manual/5.2/api/Str.html

remove pcre library, use ocaml str instead #93

remove pcre library, use ocaml str instead #93

Conversation

katrinafyi commented Jun 20, 2024 • edited Loading

katrinafyi commented Jun 20, 2024 •

edited

Loading