-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix offline generation after vectoriser and add ci #99
Conversation
Crashes in stage 7-8, but Elem[] operations should be inlined?
Also reports failures in Stage 5: Disassembly. The bits_size_of_expr failures are new.
|
02e5ce3
to
8c3897d
Compare
8c3897d
to
f8b4620
Compare
also fixup extraction due to missed case in nested slice we should now have all static-low-index extractions
I think this should fix it. It's rather awful, especially around the type-inference. I also expect performance regressions. This will need to be fixed up. Edit: A litany of new failures... I think this has significantly worsened the output quality. |
It seems the old last minute slice removal pass was disabled (likely due to me messing around). Re-enabling gets rid of the dynamic bitvector slice, with some minor changes to the output quality. Changes in: https://github.com/UQ-PAC/aslp/tree/offline-after-vec-slice Not sure how this compares with your change @katrinafyi , the last minute reduction to shift & trunc was always a bit hacky. |
89aac93
to
fe78b12
Compare
fixes after #98.