Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowed_mentions to ping messages #187

Merged
merged 2 commits into from
Dec 23, 2023
Merged

Conversation

JamesDearlove
Copy link
Member

As we disable the allowed_mentions on bot startup, messages that could ping people need to be explicitly defined. This patch adds these in to the advent cog.

Copy link
Member

@andrewj-brown andrewj-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I assume there's no way to make the roles more granular than "yes/no" - if there is, we should do that.

@andrewj-brown andrewj-brown merged commit d96efb1 into main Dec 23, 2023
3 checks passed
@andrewj-brown andrewj-brown deleted the patch-aocmissingping branch December 23, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants