Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added command to get current MC server player count #190

Merged
merged 5 commits into from
Dec 25, 2023

Conversation

Antimatter543
Copy link
Contributor

*Do /mcplayers to get player count, and current users on the minecraft server

Currently hard-coded the ip into it, this is cursed but I can't tell if RCON IP is the same as public IP.

Copy link
Member

@andrewj-brown andrewj-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review as promised. If you fix the hard-coded IP and switch it out for an env variable, I reckon it's all good.

uqcsbot/minecraft.py Outdated Show resolved Hide resolved
uqcsbot/minecraft.py Show resolved Hide resolved
Copy link
Member

@andrewj-brown andrewj-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You'll need to merge the upstream changes into your branch before I merge - there should be a button down the bottom of the PR that says "update branch", and it should be able to autoresolve.

@andrewj-brown andrewj-brown merged commit a5dd798 into UQComputingSociety:main Dec 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants