Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whatsdue: fixed to work with the new JAC system #207

Merged
merged 2 commits into from
Jul 27, 2024
Merged

Whatsdue: fixed to work with the new JAC system #207

merged 2 commits into from
Jul 27, 2024

Conversation

49Indium
Copy link
Member

Recently (semester 2 2024) UQ has changed their ECP management from ECPS to JAC. This means that many of the ECP related functions stopped working (as they were based off a old service started in 2006).

This PR rewrites most of these to work with the new system, letting whatsdue work again. There are some slight stylistic changes made to the output, due to certain links no longer being available, and the due dates for many courses actually being descriptions. ECPs from before sem 2 2024 will no longer be able to be processed, as these should no longer be needed.

There might also be some future potential to include hurdle warnings in whatsdue, as these are in the current ECP assessment tables, but are ignored in this PR.

Please review harshly, as I have done a somewhat quick job at this.

@49Indium 49Indium requested a review from GoldenRedstone July 22, 2024 14:03
@49Indium 49Indium added the bug Something isn't working label Jul 22, 2024
Copy link
Member

@GoldenRedstone GoldenRedstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good updates beyond just fixing the critical errors. Only issues were just a few docstrings that were not updated alongside. You asked me to review harshly so I also checked your spelling.

uqcsbot/utils/uq_course_utils.py Outdated Show resolved Hide resolved
uqcsbot/utils/uq_course_utils.py Outdated Show resolved Hide resolved
uqcsbot/utils/uq_course_utils.py Outdated Show resolved Hide resolved
uqcsbot/utils/uq_course_utils.py Outdated Show resolved Hide resolved
uqcsbot/utils/uq_course_utils.py Outdated Show resolved Hide resolved
uqcsbot/utils/uq_course_utils.py Outdated Show resolved Hide resolved
uqcsbot/utils/uq_course_utils.py Outdated Show resolved Hide resolved
uqcsbot/whatsdue.py Outdated Show resolved Hide resolved
uqcsbot/utils/uq_course_utils.py Show resolved Hide resolved
@49Indium
Copy link
Member Author

Thanks for catching all of that. I completely forgot about the doc strings.

@49Indium 49Indium merged commit 66c8e5e into main Jul 27, 2024
3 checks passed
@49Indium 49Indium deleted the whatsdue branch July 27, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants