Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

advent: Add user-agent header to leaderboard requests #214

Merged
merged 1 commit into from
Dec 4, 2024
Merged

advent: Add user-agent header to leaderboard requests #214

merged 1 commit into from
Dec 4, 2024

Conversation

TheOnlyMrCat
Copy link
Member

The AoC automation guidelines specify that we should have a user-agent header on outgoing requests, so here is one.

JamesDearlove
JamesDearlove approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@JamesDearlove JamesDearlove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, lgtm. We should have a user-agent most web requests like we do to UQ sites.

@TheOnlyMrCat
Copy link
Member Author

That's a good idea, I'll make a follow-up PR for that

@TheOnlyMrCat TheOnlyMrCat merged commit d7ab1b0 into main Dec 4, 2024
3 checks passed
@TheOnlyMrCat TheOnlyMrCat deleted the advent-useragent branch December 4, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesDearlove JamesDearlove JamesDearlove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheOnlyMrCat @JamesDearlove