exec 2024 #323
Merged
exec 2024 #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c12d443.
fattyhope
requested review from
LimaoC and
jenseni-git
and removed request for
LimaoC
|
Hmmmm, I prefer #322. |
Closed
jenseni-git
requested changes
Mar 19, 2024
| @@ -10,7 +10,7 @@ | |||
| <!-- <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/[email protected]/css/bulma.min.css"> --> | |||
| {{ "<!-- Custom CSS -->" | safeHTML }} | |||
| {{ "<!-- Font Awesome -->" | safeHTML }} | |||
| <script defer src="https://use.fontawesome.com/releases/v6.1.1/js/all.js"></script> | |||
| <script defer src="https://use.fontawesome.com/releases/v6.5.1/js/all.js"></script> | |||
There was a problem hiding this comment.
Suggested change
| <script defer src="https://use.fontawesome.com/releases/v6.5.1/js/all.js"></script> | |
| <script defer src="https://use.fontawesome.com/releases/v6.1.1/js/all.js"></script> |
There was a problem hiding this comment.
I'm actually happy for the Font Awesome version to be bumped, no reason it can't be
There was a problem hiding this comment.
Personally (and due to precedent), I'd also prefer full names on the about page. Otherwise after Discord tag changes I think it's all good.
Note for mergers: Make sure you squash and merge this commit, as Jackie has reverted in this PR. Also squashes look neater (imo)
jenseni-git
approved these changes
Mar 27, 2024
Fixes discord tags to reference the same type of tag (tag, not current nickname). Adds full names to names of committee members.
|
Yay woo finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe I need to create a separate branch to only update the exec of 2024 since I have random commits from last year, see below:
Here's a snapshot of the component I want to merge to main.
Let me know if there are any typos and/or changes wanted to be made.
Thanks,
Jackie