Team 2 alasdair branch #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… shots per second.
…han just weapon towers.
updated to return without editing firerate if division by zero is attempted.
The-AhmadAA
reviewed
Sep 8, 2023
| @@ -203,7 +203,11 @@ private boolean isTargetVisible() { | |||
| private void changeFireRateInterval(int perMinute) { | |||
| float oldFireSpeed = 1/fireRateInterval; | |||
| float newFireSpeed = oldFireSpeed + perMinute/60f; | |||
| fireRateInterval = 1/newFireSpeed; | |||
| if (newFireSpeed == 0) { | |||
| return; | |||
There was a problem hiding this comment.
updated this to return without doing anything rather than changing the firerate
Fixed failing test after previous edit
|
Looks good, nice pick up of the edge case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Averts divide by zero edge case if a tower's fire rate is reduced to 0 shots per second. If TowerCombatTask attempts to set it's fireRateInterval to 1/0, it will instead be set to 0.
TowerUpgraderComponent is now part of all towers made, not just weapon towers.