-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding New Tower Variants and Upgrade Feature #127
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to make an upgrade to the tower. No upgrade types do anything yet.
…ttack stat in the CombatStatsComponent of the same entity.
…to CombatStatsComponent to alter the fullHealth variable.
… added functionality to TowerCombatTask for supporting fire rate upgrades.
Team 2 alasdair branch
…pleted the createFireTower method in TowerFactory.
…ower.png, stun_tower.atlas and finished the base functionality for createStunTower method in TowerFactory.
… to DroidTower's animations
… shots per second.
…han just weapon towers.
updated to return without editing firerate if division by zero is attempted.
Fixed failing test after previous edit
Team 2 alasdair branch
…troller and mehtod in towerFactory classes.
Created and implemented animations for StunTower and FireTower.
…ding to game events
Happy for this merge to go ahead, clear and well documented
Hasakev
approved these changes
Sep 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problems found, LGTM 👍
(We're getting ready to implement all these new turrets into the turret selection screen)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three new tower variants have been introduced: the
Stun_Tower
that fires projectiles to immobilize mobs, theFire_Tower
that spews fire to damage mobs, and the Droid which shoots projectiles that decelerate mobs. The upgrade features for these towers are developed but haven't been integrated into theTower Factory
yet. The Droid tower isn't firing projectiles yet, as we're awaiting the slow-moving projectile feature to be completed by the projectile team. Feel free to ask if any aspect is unclear.edited: Just Integrated slow-effect projectile with the Droid