Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Junit tests for TNTTowerCombatTask and DroidCombatTask #134

Merged
merged 7 commits into from
Sep 10, 2023
Merged

Added Junit tests for TNTTowerCombatTask and DroidCombatTask #134

merged 7 commits into from
Sep 10, 2023

Conversation

Mohamad11Dab
Copy link
Contributor

Added Junit tests for TNTTowerCombatTask and DroidCombatTask and fixed some code smells. Don't hesitate to give some feedbacks.

@Mohamad11Dab Mohamad11Dab added documentation Improvements or additions to documentation team 2 sprint 2 labels Sep 10, 2023
@Mohamad11Dab Mohamad11Dab added this to the Sprint 2 milestone Sep 10, 2023
Hasakev
Hasakev approved these changes Sep 10, 2023
View reviewed changes
Copy link
Contributor

@Hasakev Hasakev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, All tests are relevant.

(You guys have really figured out mockito)

@Hasakev Hasakev merged commit 456a6d7 into main Sep 10, 2023
2 checks passed
@Mohamad11Dab Mohamad11Dab changed the title Team 2 towers Added Junit tests for TNTTowerCombatTask and DroidCombatTask Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hasakev Hasakev Hasakev approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation sprint 2 team 2
Projects
2023 Studio 3 Project
Status: Done
Milestone
Sprint 2
Development

Successfully merging this pull request may close these issues.
3 participants
@Mohamad11Dab @Hasakev @The-AhmadAA