Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team-2--Engineers-Praneet #148

Merged
merged 15 commits into from
Sep 12, 2023
Merged

Team-2--Engineers-Praneet #148

merged 15 commits into from
Sep 12, 2023

Conversation

praneetdhoolia
Copy link
Contributor

-Added event to check for projectile firing in EngineerCombatTask.
-Reset list of hits for isTargetVisible() to detect a fresh set of targets.
-Added EngineerCombatTaskTest.

@praneetdhoolia praneetdhoolia requested review from The-AhmadAA, Mohamad11Dab and meganroxburgh and removed request for Mohamad11Dab September 12, 2023 01:27
@praneetdhoolia praneetdhoolia self-assigned this Sep 12, 2023
@praneetdhoolia praneetdhoolia added help wanted Extra attention is needed task team 2 sprint 2 and removed help wanted Extra attention is needed labels Sep 12, 2023
@praneetdhoolia praneetdhoolia added this to the Sprint 2 milestone Sep 12, 2023
@praneetdhoolia praneetdhoolia linked an issue Sep 12, 2023 that may be closed by this pull request
20 tasks
Copy link
Contributor

@Mohamad11Dab Mohamad11Dab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix merge conflicts instead of commenting them out?

@The-AhmadAA
Copy link
Contributor

I can't review as this is part of my feature. Thanks for reviewing @Mohamad11Dab

@The-AhmadAA The-AhmadAA merged commit 172c9fb into main Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[Team 2] Engineers Task Ticket
3 participants