Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Team 2 engineers - Final sprint 2 merge #154

Merged
merged 8 commits into from
Sep 12, 2023
Merged

Team 2 engineers - Final sprint 2 merge #154

merged 8 commits into from
Sep 12, 2023

Conversation

The-AhmadAA
Copy link
Contributor

This pull request inlcudes final tweaks and minor fixes for the engineers feature for sprint 2. Specifically:

  • Engineer count now updates in the display if a non-default limit is set
  • code smell fixes

@The-AhmadAA The-AhmadAA self-assigned this Sep 12, 2023
@The-AhmadAA The-AhmadAA added this to the Sprint 2 milestone Sep 12, 2023
@The-AhmadAA The-AhmadAA linked an issue Sep 12, 2023 that may be closed by this pull request
[Team 2] Engineers Task Ticket #80
Closed
20 tasks
@The-AhmadAA The-AhmadAA merged commit d655b6d into main Sep 12, 2023
@The-AhmadAA The-AhmadAA deleted the Team-2--Engineers branch October 11, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hasakev Hasakev Hasakev approved these changes

@ryandmcneilly ryandmcneilly Awaiting requested review from ryandmcneilly

@meganroxburgh meganroxburgh Awaiting requested review from meganroxburgh

@BlairCannon97 BlairCannon97 Awaiting requested review from BlairCannon97

@ThivanW ThivanW Awaiting requested review from ThivanW

Assignees

@The-AhmadAA The-AhmadAA

Labels
feature sprint 2 task team 2
Projects
2023 Studio 3 Project
Status: Done
Milestone
Sprint 2
Development

Successfully merging this pull request may close these issues.

[Team 2] Engineers Task Ticket
2 participants
@The-AhmadAA @Hasakev