Team-3 error fixed #158
Closed
Team-3 error fixed #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aadityayadav17
requested review from
The-AhmadAA and
Mohamad11Dab
and removed request for
Jonoym
The-AhmadAA
requested changes
Sep 12, 2023
There was a problem hiding this comment.
GameEndService is someone elses feature and you should not be modifying it. See #132
| @@ -213,7 +213,6 @@ public void create() { | |||
| private void displayUI() { | |||
| Entity ui = new Entity(); | |||
| ui.addComponent(new GameAreaDisplay("Box Forest")); | |||
| ui.addComponent(ServiceLocator.getGameEndService().getDisplay()); | |||
There was a problem hiding this comment.
You have deleted a change required by another team's feature. Restore this and fix your error properly
|
|
|
We are removing this feature from this sprint due to time constraints. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Game running now