Team 4 Levels - General Levels Updates #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaveManager WaveService WaveClass Further implemtation required
Explains new functionality about spawning waves
…s remaining) Need to set what happens when the level is completed, as game currently crashes due to index out of bounds error.
…aveClass and WaveFactory
…into Team-4---Waves
…eTask to return the sounds Array.
…eCount in the WaveTask.java when a new wave is started. This will be used hopefully for some UI showing the player what wave they are in.
…ves-max # Conflicts: # source/core/src/main/com/csse3200/game/components/tasks/waves/WaveTask.java # source/core/src/main/com/csse3200/game/services/WaveService.java
… lane the next mob will spawn in
… lane the next mob will spawn in
…to aid in testing of the waves feature.
…ave been added to wave related classes.
…ll be spawned in WaveService.java. Also made the wave start timestamp update in LevelWaves.java (the first time waves are made) & in WaveTask.java (For when a wave ends and a new one starts).
# Conflicts: # source/core/src/main/com/csse3200/game/components/tasks/waves/LevelWaves.java
max9753
requested review from
ryandmcneilly,
Hasakev,
MiniSoda17,
The-AhmadAA and
Mohamad11Dab
There was a problem hiding this comment.
There appears to be no function for pausing the wave timer mid-game, only startWaveTimer() and stopWaveTimer() which appear to only work at the setup and cleanup of the stage.
I'd like for WaveTask to have some method of pausing the in-between waves timer that can I can access with the pause menu entity.
shiv-0831
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request include several features of levels that have been created such as: