Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team 7 tower extension #213

Merged
merged 39 commits into from
Oct 3, 2023
Merged

Team 7 tower extension #213

merged 39 commits into from
Oct 3, 2023

Conversation

ThivanW
Copy link
Contributor

@ThivanW ThivanW commented Oct 2, 2023

Added 3 new towers; ricochet tower, pierce tower and fireworks tower. The main files that were added and changed were TowerFactory, RicochetTowerCombatTask, PierceTowerCombatTask and FireworksTowerCombatTask. The three tasks also have their respective test files as well. Further development was done to the wall tower in order to change the sprite and implement a death animation for the tower.

ThivanW and others added 24 commits October 1, 2023 21:14
…urrently spawned in and is using the fireworks projectile and the tower combat has been modified for the charging start and end states created animation controller, atlas files, sprite sheet for the animations.(current tower state : almost finished)
…wer as it is doing the death animation sometimes while its not doing it sometimes
@ThivanW ThivanW self-assigned this Oct 2, 2023
@Hasakev
Copy link
Contributor

Hasakev commented Oct 3, 2023

Hi, just a reminder to pull main and merge conflicts every time a new PR prior is pushed. Also make sure to fix any game unit tests

@ThivanW ThivanW requested review from Hasakev and The-AhmadAA October 3, 2023 02:00
Copy link
Contributor

@Mohamad11Dab Mohamad11Dab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Guys, you have to pull from main before, the start screen and storyline have been changed.

Copy link
Contributor

@Hasakev Hasakev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The three new turrets function as expected LGTM

@Hasakev Hasakev self-requested a review October 3, 2023 02:26
@Hasakev Hasakev merged commit a508d2d into main Oct 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants