Team 4 waves #221
Merged
Team 4 waves #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eviously spawnDelay was hardcoded. Spawn delay can also be accessed by the WaveService if the UI or other teams want to use it. Added WaveServiceTest.java as well.
# Conflicts: # source/core/src/main/com/csse3200/game/entities/factories/WaveFactory.java
samsully
requested review from
Hasakev,
MiniSoda17,
The-AhmadAA and
BlairCannon97
Hasakev
approved these changes
Oct 3, 2023
Hasakev
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request includes a change to the WaveService to make it work better for the UI team. It also includes a test for WaveService but it is currently broken and being fixed, unlikely before 3pm today so it's disabled.
Fixed testing issues of previous pull request 216