Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for TurretSelectScreen #222

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Bug fix for TurretSelectScreen #222

merged 2 commits into from
Oct 3, 2023

Conversation

The-AhmadAA
Copy link
Contributor

This PR fixes a bug where if between 1 and 4 towers are selected in the turretSelectScreen, it causes the game to crash
#217

@The-AhmadAA The-AhmadAA added the bug Something isn't working label Oct 3, 2023
@The-AhmadAA The-AhmadAA added this to the Sprint 3 milestone Oct 3, 2023
@The-AhmadAA The-AhmadAA self-assigned this Oct 3, 2023
@ryandmcneilly
Copy link
Contributor

On Linux it looks like the crash still happens (SIGSEV error rather than IndexOutOfBounds) but this might only be a Linux / macOS issue (I'll let Kevin verify if it works on his end). Just a reminder about the bug where you can select multiple turrets when placing them. The debug area for the buttons for the turret placement is still on, however that should be an easy fix.

Copy link
Contributor

@Hasakev Hasakev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug seems to be fixed LGTM (tested 1,2,3,4 in game)

@Hasakev Hasakev merged commit be827ea into main Oct 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

3 participants