Team 7 tower stat alterations #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-AhmadAA
reviewed
Oct 15, 2023
There was a problem hiding this comment.
Suggestion for maintainability, could this fetch values from the config files you defined?
The-AhmadAA
reviewed
Oct 15, 2023
| @@ -21,7 +21,7 @@ public class CurrencyTask extends DefaultTask implements PriorityTask { | |||
| private long endTime; | |||
| private int interval; | |||
| private final Scrap scrap = new Scrap(); // currency to update | |||
| private final int currencyAmount = scrap.getAmount(); // amount of currency to update | |||
| private final int currencyAmount = 30; // amount of currency to update | |||
There was a problem hiding this comment.
as with my other comment, could this be modified to fetch the scrap increment value from the config file?
The-AhmadAA
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Altered the health, damage, and cost of all towers and changed the income amount to better match the new costs of the towers. Also fixed a bug where the towers health would be set to 5 after opening the upgrade ui.