Team 4 Bug Fixes & Code Smell Fixes #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing when it spawned WaterSlimes
…velWaves as instructed by SonarCloud.
… area alone. Hopefully none of NPC factory was messed with :)
…be assertEquals etc.
…4---Waves # Conflicts: # source/core/src/main/com/csse3200/game/entities/factories/WaveFactory.java
…tudio-3 into Team-4---Waves
max9753
requested review from
Hasakev,
MiniSoda17,
The-AhmadAA,
Mohamad11Dab and
AlasdairS4698737
The-AhmadAA
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a bug fix and several minor code smell fixes in wave & service files. Hopefully none of the code smell changes break anything :).