Team 1 Quality of Life changes to mobs #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om/UQcsse3200/2023-studio-3 into Team-1--Jono-True-Love
MiniSoda17
requested review from
ryandmcneilly,
Hasakev,
SonjaMcNeilly,
The-AhmadAA,
Mohamad11Dab,
samsully,
meganroxburgh and
BlairCannon97
The-AhmadAA
reviewed
Oct 16, 2023
| @@ -30,6 +32,7 @@ public class DodgingComponent extends Component { | |||
| private float dodgeSpeed = 1.75f; | |||
| private float originalSpeed; // Original entity vertical speed | |||
| private PhysicsEngine physics; | |||
| private Random random = new Random(); | |||
There was a problem hiding this comment.
Random keeps popping up as an issue on SonarCloud, is there anything else that could be used instead?
There was a problem hiding this comment.
@MiniSoda17 You can use RandUtils to generate random numbers
The-AhmadAA
approved these changes
Oct 16, 2023
…erCountDisplay is updated
BlairCannon97
approved these changes
Oct 16, 2023
…b.com> Co-authored-by: gregchan550 <[email protected]>
meganroxburgh
approved these changes
Oct 16, 2023
This was
linked to
issues
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates