Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team 7 - Fix code smells for the towers #297

Merged
merged 13 commits into from
Oct 17, 2023
Merged

Conversation

lenhatminh451
Copy link
Contributor

This pull request includes changes to reduce the code smells in the tower's tasks, tests and configs. Almost all code smells have been fixed, but some still need to be rechecked on SonarCloud after merging with the main.

@lenhatminh451 lenhatminh451 added this to the Sprint 4 milestone Oct 17, 2023
@lenhatminh451 lenhatminh451 self-assigned this Oct 17, 2023
@lenhatminh451 lenhatminh451 changed the title Team 7 - Fix code smells for the towers #289 Team 7 - Fix code smells for the towers Oct 17, 2023
Copy link
Contributor

@Hasakev Hasakev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to merge main again

@The-AhmadAA The-AhmadAA merged commit 91d5dcc into main Oct 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants