Team 4 - Waves - Final Code Smell Fixes & New Tests for WaveService Added. #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max9753
requested review from
guoweiyang,
ryandmcneilly,
Hasakev,
MiniSoda17,
The-AhmadAA and
Mohamad11Dab
Hasakev
approved these changes
Oct 17, 2023
yes, perhaps but I wont mess with that one because I don't remember making it I think it was another member. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be our final PR I think which fixes several code smells and add some new testing coverage to WaveService in WaveServiceTest.java.
Should be no conflicts as these files should not have been touched by anyone else hopefully :).
Happy reviewing!