Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lpj wetlands unit changes #65

Closed
wants to merge 3 commits into from

Conversation

SwordSaintLancelot
Copy link
Collaborator

@SwordSaintLancelot SwordSaintLancelot commented Apr 15, 2024

Description

This script changes the units for the lpjeosim-wetlandch4-daygrid v2 dataset and pushes the updated data onto the s3 bucket.

What type of docs is this?

Data transformation notebook

Checklist

Since the script only transforms the units of the delivered COGs, the structure of the notebook is slightly different.

  • The first cell contains the rendering information with author and data
  • The notebook has an Approach section
  • All the packages that are imported in the notebooks are used within the notebook
  • Dependency installs are in a non-executable cell (Markdown with a code block) as a single-line %pip install abc def statement
  • All imports are at the top of the notebook
  • Any complex geometries are accessed from remote storage
  • Each code cell comes after a markdown cell containing explantory text
  • All cells in the notebook book have been run in order with a fresh kernel (cell numbers should be 1, 2, 3, 4, ...)

@SwordSaintLancelot SwordSaintLancelot self-assigned this Apr 15, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Apr 15, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://US-GHG-Center.github.io/ghgc-docs/pr-preview/pr-65/
on branch gh-pages at 2024-04-15 14:39 UTC

Copy link
Contributor

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the commented-out code and perhaps omit the print(counter), so we do not have that long output 1,2,3,4,5,...

Dotting the i's would be to sort the imports into whether they are system libraries (os, re, json, datetime etc.) or third-party (xarray, pandas, etc.).

@SwordSaintLancelot
Copy link
Collaborator Author

This PR is no longer required as the data POC is now providing us with the data in transformed units.

@slesaad slesaad deleted the lpj-wetlands-unit-changes branch July 9, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants