Adding 2.0 validate ChargingStationMaxProfile #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph <[email protected]>
couryrr-afs
reviewed
Apr 26, 2024
Signed-off-by: Christoph <[email protected]>
christopher-davis-afs
suggested changes
Apr 26, 2024
Signed-off-by: Christoph <[email protected]>
|
With the new workflow, I wonder if this should be squashed to one commit, since the other two commits are modifications to the changes introduced in the first. Other than that, LGTM |
christopher-davis-afs
approved these changes
Apr 26, 2024
folkengine
deleted the
folkengine/k01_validate_ChargingStationMaxProfile_III
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Handles K01.FR.38 and K04.FR.03 from the OCPP 2.0.1 specification.
Issue ticket number and link
K01 - Charging Station Max Profile Validation #99
Checklist before requesting a review