Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smart_charging: Handle profile updates per K01.FR.05 #11

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

christopher-davis-afs
Copy link

Describe your changes

Handles K01.FR.05. There are two open questions on this one:

  • The spec doesn't specify whether or not it's valid to have a profile with the same id when one with a ChargingStationExternalConstraints already exists - just that ChargingStationExternalConstraints profiles can't be replaced. For this PR currently I assume it is, since the purpose is different and the main thing to avoid is having profiles with the same stackLevel and purpose at the same time.
  • When the spec says to replace the profile, it doesn't make sense (to me) to replace a station-wide profile with an evse-specific profile. That said, the spec doesn't clarify that detail.

Issue ticket number and link

Checklist before requesting a review

Copy link

@couryrr-afs couryrr-afs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - ☕

@couryrr-afs couryrr-afs merged commit aca0d08 into feature/k01-add-profile Apr 30, 2024
2 checks passed
@christopher-davis-afs christopher-davis-afs deleted the cdavis/k01-profile-update branch May 1, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants