Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Full Validate Profile Method #5

Conversation

christopher-davis-afs
Copy link

Describe your changes

Issue ticket number and link

Checklist before requesting a review

@christopher-davis-afs christopher-davis-afs force-pushed the cdavis/validate-profile-full-v201 branch from 116b598 to bed515a Compare April 17, 2024 20:05
@christopher-davis-afs christopher-davis-afs force-pushed the cdavis/validate-profile-full-v201 branch from bed515a to 5d44c54 Compare April 18, 2024 14:16
Copy link

@couryrr-afs couryrr-afs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - ☕

I would approve but I think we need to iron out that bit of the flow.

@christopher-davis-afs christopher-davis-afs force-pushed the cdavis/validate-profile-full-v201 branch 3 times, most recently from 5893a06 to a27ead5 Compare April 26, 2024 13:03
@christopher-davis-afs christopher-davis-afs force-pushed the cdavis/validate-profile-full-v201 branch 2 times, most recently from 87c2232 to 8f7f562 Compare April 26, 2024 19:38
@christopher-davis-afs christopher-davis-afs marked this pull request as ready for review April 26, 2024 19:40
Copy link

@couryrr-afs couryrr-afs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - ☕

@christopher-davis-afs christopher-davis-afs force-pushed the cdavis/validate-profile-full-v201 branch from 8f7f562 to cf545e6 Compare May 1, 2024 12:33
@christopher-davis-afs christopher-davis-afs force-pushed the feature/k01-validate-profile branch from bc38476 to 80dffa8 Compare May 1, 2024 12:39
@christopher-davis-afs christopher-davis-afs force-pushed the cdavis/validate-profile-full-v201 branch 2 times, most recently from 39b7ec3 to 90c1605 Compare May 1, 2024 12:46
…period

This was missed in prior commits.

Signed-off-by: Christopher Davis <[email protected]>
Reworks how we handle and test conforming the validity periods for
K01.FR.06.

Signed-off-by: Christopher Davis <[email protected]>
@christopher-davis-afs christopher-davis-afs force-pushed the cdavis/validate-profile-full-v201 branch from 90c1605 to 3eb8051 Compare May 1, 2024 12:53
@christopher-davis-afs
Copy link
Author

Re-ordered the commit history to make things make a little more sense chronologically. Should be good to go now.

@gberardi-pillar gberardi-pillar merged commit 8ceb4a0 into feature/k01-validate-profile May 1, 2024
2 checks passed
@christopher-davis-afs christopher-davis-afs deleted the cdavis/validate-profile-full-v201 branch May 1, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants