Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement k01 fr 06 validity period check #6

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

couryrr-afs
Copy link

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • [ x ] I have performed a self-review of my code
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] If OCPP 2.0.1: I have updated the OCPP 2.0.1 status document
  • [ x ] I read the contribution documentation and made sure that my changes meet its requirements

Tests for K01.FR.39 were previously mislabeled for K01.FR.06.

This commit relabels these tests.

Signed-off-by: Christopher Davis <[email protected]>
@couryrr-afs couryrr-afs changed the base branch from main to feature/k01-validate-profile April 22, 2024 14:53
Copy link

@christopher-davis-afs christopher-davis-afs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this feels like a big block of logic with a lot of if statements, and I'm wondering: is there a way to simplify this into math?

@couryrr-afs couryrr-afs force-pushed the couryrr/k01-fr-06 branch 2 times, most recently from c099508 to 70f243c Compare April 23, 2024 16:15
@couryrr-afs couryrr-afs merged commit 981321f into feature/k01-validate-profile Apr 25, 2024
2 checks passed
@couryrr-afs couryrr-afs deleted the couryrr/k01-fr-06 branch June 12, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants