Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some app descriptions + imager is a required pkg #140

Merged
merged 9 commits into from
Jun 14, 2017

Conversation

lindsayplatt
Copy link
Contributor

@lindsayplatt lindsayplatt commented Jun 12, 2017

  1. Add imager as a required package to viz.yaml. Actually, it should be installed when you install vizlab.
  2. All app descriptions for add in short description of each application at the top of the page.  #107.

@eread-usgs
Copy link
Contributor

@lindsaycarr I'd prefer to review this text on test- easier on the eyes. I'm good w merging it after walker gives it a review.

Also, @wdwatkins I just noticed that there's a timezone indicated here in the metadata- is that from GA or manually added? Either way, if it is reliable indication of timezone set by the admin and is consistently known for each app, would you please add that to the time of day plots for each figure?

@eread-usgs
Copy link
Contributor

@wdwatkins and @lindsaycarr I just looked and saw that most apps do have timezones, some don't. Since most of the apps do have timezone, and I believe @wdwatkins said there's not an automated way to bring this in, can one of you please add, manually, the time zones set by the GA administrator to each app that does not have that info? @wdwatkins has access to all of the accounts, so it's probably easiest for him to take on. Please work on this in the next week or so- let me know if you don't have availability for that. related to #102 #102

@jiwalker-usgs jiwalker-usgs merged commit a4fcad3 into USGS-VIZLAB:master Jun 14, 2017
@wdwatkins
Copy link
Collaborator

You can get the timezone for the particular account from google, it's just not a part of the normal fetch workflow. I can add them to any that are missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants