use vizlab's export/publish to put data in target/data #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -170,6 +174,7 @@ process: | |||
| scripts: [scripts/process/save_map.R] | |||
| depends: | |||
| map_data: county_map_data | |||
| mimetype: application/geo+json | |||
There was a problem hiding this comment.
I wrote this in the vizlab PR, but interested in the difference between geo+json and geojson here
There was a problem hiding this comment.
sorry, all i know is https://www.iana.org/assignments/media-types/application/geo+json ¯\_(ツ)_/¯. i'm curious, too
lindsayplatt
approved these changes
Jan 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #37 and related concerns in the discussion of #35. i.e., we should be able to host this on CHS now. Relies on an open vizlab PR, USGS-VIZLAB/vizlab#328.
This PR is separate from my other open PR, #36, and the two of them work separately. But they also work together, so I'm hoping (1) there won't be merge conflicts and (2) if there are, they can be resolved pretty easily with the knowledge that there aren't any real conflicts. That said, I'm gonna be gone Monday and so @lindsaycarr you might have to deal with the merging if we're gonna get these changes in for Tech Tues.