Changes for null data

For #68 and #76
UTDNebula · Dec 15, 2024 · ee7a23f · ee7a23f
1 parent df8e1f0
commit ee7a23f
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 9 deletions.
diff --git a/src/components/CourseOverview.tsx b/src/components/CourseOverview.tsx
@@ -14,7 +14,7 @@ const CourseOverview = ({ header, grades }: CourseOverviewProps) => {
   const isCourse = typeof header !== 'string';
   return (
     <div className="flex flex-col items-center gap-2">
-      <p className="text-2xl font-bold">
+      <p className="text-2xl font-bold text-center">
         {isCourse ? searchQueryLabel(header) : header}
       </p>
       {isCourse && (

diff --git a/src/components/SearchResultsTable.tsx b/src/components/SearchResultsTable.tsx
@@ -226,7 +226,8 @@ function Row({
                 <Rating sx={{ fontSize: 25 }} readOnly />
               </Skeleton>
             )) ||
-            (rmp.state === 'done' && (
+            (rmp.state === 'done' && rmp.data.numRatings == 0 && <></>) ||
+            (rmp.state === 'done' && rmp.data.numRatings != 0 && (
               <Tooltip
                 title={'Professor rating: ' + rmp.data.avgRating}
                 placement="top"
@@ -331,16 +332,16 @@ const SearchResultsTable = ({
         const bRmp = rmp[searchQueryLabel(convertToProfOnly(b))];
         //drop loading/error rows to bottom
         if (
-          (!aRmp || aRmp.state !== 'done') &&
-          (!bRmp || bRmp.state !== 'done')
+          (!aRmp || aRmp.state !== 'done' || aRmp.data.numRatings == 0) &&
+          (!bRmp || bRmp.state !== 'done' || bRmp.data.numRatings == 0)
         ) {
           // If both aRmp and bRmp are not done, treat them as equal and return 0
           return 0;
         }
-        if (!aRmp || aRmp.state !== 'done') {
+        if (!aRmp || aRmp.state !== 'done' || aRmp.data.numRatings == 0) {
           return 9999;
         }
-        if (!bRmp || bRmp.state !== 'done') {
+        if (!bRmp || bRmp.state !== 'done' || bRmp.data.numRatings == 0) {
           return -9999;
         }
         const aRating = aRmp?.data?.avgRating ?? 0; // Fallback to 0 if undefined

diff --git a/src/components/SingleProfInfo.tsx b/src/components/SingleProfInfo.tsx
@@ -52,6 +52,31 @@ function SingleProfInfo({ rmp }: Props) {
     );
   }
 
+  if (rmp.data.numRatings == 0) {
+    return (
+      <Grid container spacing={2} className="p-4">
+        <Grid item xs={6}>
+          <p className="text-xl font-bold">
+            {rmp.data.numRatings.toLocaleString()}
+          </p>
+          <p>Ratings given</p>
+        </Grid>
+        <Grid item xs={12}>
+          <a
+            href={
+              'https://www.ratemyprofessors.com/professor/' + rmp.data.legacyId
+            }
+            target="_blank"
+            className="underline text-blue-600 hover:text-blue-800 visited:text-purple-600"
+            rel="noreferrer"
+          >
+            Visit Rate My Professors
+          </a>
+        </Grid>
+      </Grid>
+    );
+  }
+
   const topTags = rmp.data.teacherRatingTags.sort(
     (a, b) => b.tagCount - a.tagCount,
   );
@@ -61,11 +86,15 @@ function SingleProfInfo({ rmp }: Props) {
   return (
     <Grid container spacing={2} className="p-4">
       <Grid item xs={6}>
-        <p className="text-xl font-bold">{rmp.data.avgRating}</p>
+        <p className="text-xl font-bold">
+          {rmp.data.avgRating > 0 ? rmp.data.avgRating : 'N/A'}
+        </p>
         <p>Professor rating</p>
       </Grid>
       <Grid item xs={6}>
-        <p className="text-xl font-bold">{rmp.data.avgDifficulty}</p>
+        <p className="text-xl font-bold">
+          {rmp.data.avgDifficulty > 0 ? rmp.data.avgDifficulty : 'N/A'}
+        </p>
         <p>Difficulty</p>
       </Grid>
       <Grid item xs={6}>
@@ -76,7 +105,9 @@ function SingleProfInfo({ rmp }: Props) {
       </Grid>
       <Grid item xs={6}>
         <p className="text-xl font-bold">
-          {rmp.data.wouldTakeAgainPercent.toFixed(0) + '%'}
+          {rmp.data.wouldTakeAgainPercent > 0
+            ? rmp.data.wouldTakeAgainPercent.toFixed(0) + '%'
+            : 'N/A'}
         </p>
         <p>Would take again</p>
       </Grid>