Compare Table will not display rmp data if there are no reviews

UTDNebula · Nov 10, 2024 · 4028296 · 4028296
1 parent cbf56ce
commit 4028296
Showing 1 changed file with 7 additions and 11 deletions.
diff --git a/src/components/common/CompareTable/compareTable.tsx b/src/components/common/CompareTable/compareTable.tsx
@@ -143,7 +143,7 @@ function GradeOrRmpRow<T>({
                 <Typography className="text-base">{loadingFiller}</Typography>
               </Skeleton>
             )) ||
-            (value.state === 'done' && getValue(value.data) !== -1 && (
+            (value.state === 'done' && getValue(value.data) > 0 && (
               <Tooltip
                 title={`${name}: ${formatValue(getValue(value.data))}`}
                 placement="top"
@@ -274,16 +274,12 @@ function GradeAndRmpRow({
                         </Typography>
                       </Skeleton>
                     )) ||
-                    (rmp.state === 'done' &&
-                      getRmpValue(rmp.data as RMPInterface) == 0 && (
-                        <CloseIcon />
-                      )) ||
-                    (rmp.state === 'done' &&
-                      getRmpValue(rmp.data as RMPInterface) != 0 && (
-                        <Typography className="text-base inline">
-                          {rmpValue}
-                        </Typography>
-                      )) ||
+                    (rmp.state === 'done' && rmpValue == 0 && <CloseIcon />) ||
+                    (rmp.state === 'done' && rmpValue != 0 && (
+                      <Typography className="text-base inline">
+                        {rmpValue}
+                      </Typography>
+                    )) ||
                     null}
                 </span>
               </Tooltip>