Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading jumping #296

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Fix loading jumping #296

merged 5 commits into from
Nov 11, 2024

Conversation

TyHil
Copy link
Member

@TyHil TyHil commented Oct 31, 2024

Overview

The UI jumps around a bit as it transitions through the 2 loading states to the final done state.

What Changed

This fixes that by making the name take up all remaining width in the table so the placement of the last 2 columns is not dependent on the longest professor name.

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
utd-trends ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2024 11:23pm

@TyHil TyHil marked this pull request as draft October 31, 2024 15:30
@AbhiramTadepalli
Copy link
Contributor

@TyHil commit the fixes to #291

@TyHil
Copy link
Member Author

TyHil commented Nov 8, 2024

Give it a check now

Copy link
Contributor

@AbhiramTadepalli AbhiramTadepalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡magnífico!

@AbhiramTadepalli AbhiramTadepalli merged commit 03f9e1f into develop Nov 11, 2024
3 checks passed
@AbhiramTadepalli AbhiramTadepalli deleted the loading-jumping branch November 11, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants