Search bolding #99
Merged
Search bolding #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
Jake3231
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add bolding to searches. If you search "CS 12" for example, results will look like CS 1200, CS 1200 John Cole, etc.
This uses, as suggested by MUI, the autosuggest-highlight library: https://github.com/moroshko/autosuggest-highlight.
What Changed
Changed
renderOptionin both search bars. Removing theclassNameproperty on it also fixed the highlighting issues.I used regex to split any CS1200 or 1200CS into CS 1200 or 1200 CS respectively. Also supporting partial numbers like CS1, CS12, and CS120 and numbers with letters in them like CS5V81 of which I think there is only ever the possibility of a V in the second position.