-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix package critical vulnerabilities #376
Conversation
…/core` and `@babel/preset-env`
…kage version `3.0.3`
About warnings when installingWhen installing the package, I wanted to get as as much as possible a clean output, without warnings.
However it seems those warming don't show up when installing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Michael for your contribution! UXPin is already looking better with less warnings when installing the CLI!
LGTM! 🧑💻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog review, LGTM 🌮
Goal
An attempt to fix the "critical" issues reported by
yarn audit
command (17
critical issues after the3.0.2
release, see #368 for details).The strategy was to run
yarn audit
from this repo, fixing the "critical" issues one by one, ensuring that tests pass.remap-istanbul
(not used any more)stubby
@babel/core
and@babel/preset-env
nyc
globby
@textlint/markdown-to-ast
instead ofmarkdown-to-ast
(deprecated) and upgrade types accordinglyFor vulnerabilities related to
minimist
andchrome-launcher
packages, I had to use Yarn resolutions by adding this to the package.json "resolutions"
object in the package.json:Also this PR fixes a warming about missing peer dependencies when installing:
How to check
I released a
dev
version of the package on both registries:3.0.3-dev.124
on public NPM3.0.3-dev.123
on private GitHubSteps:
@uxpin/merge-cli
dependency with one of the versions mentioned aboveyarn install
warning "@uxpin/merge-cli > @uxpin/[email protected]" has unmet peer dependency "ast-types@^0.12.4".
is goneyarn audit
, there should show no vulnerabilities from@uxpin/merge-cli
Example, from MUI repo: