Ensure ip_forward when deploying with th role. Closes #159 #4
Conversation
tasks/system/forwarding.yml
Outdated
| @@ -7,7 +7,7 @@ | |||
| sysctl_set: true | |||
| state: present | |||
| reload: true | |||
| when: not lookup('env', 'IN_MOLECULE') | d(true, true) | bool | |||
| when: not ( lookup('env', 'IN_MOLECULE') ) | d(true, true) ) | bool | |||
There was a problem hiding this comment.
Did you get to try this? It gives me an error:
FAILED! => {"msg": "The conditional check 'not ( lookup('env', 'IN_MOLECULE') ) | d(true, true) ) | bool' failed. The error was: template error while templating string: unexpected ')'.
There is a parenthesis to spare
There was a problem hiding this comment.
I suppose it was a typing error, and the intention was to leave it as below (line 20)
There was a problem hiding this comment.
After reaching the same conclusion, I see that you had already solved it and commented here
The correct way for it to work in both scenarios (normal and molecule test) is:
when: not lookup('env', 'IN_MOLECULE') | d(false, true) | boolThere was a problem hiding this comment.
Sorry, It was a failed commit. Fix hereafter. Maybe we can stash commits for merge.
|
Let's abandon the present PR and work on PR #6. |
Accordig to the issue #159 at the upstream role, I propose this patch.
Conforme a la issue #159 del rol upstream, propongo este patch.