Fisrt working proposal for #2 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulvida
force-pushed
the
Inc2-client_user
branch
from
c27f01d to
1bcca14
Compare
ulvida
force-pushed
the
Inc2-client_user
branch
from
1bcca14 to
ef6f45f
Compare
ulvida
added a commit
that referenced
this pull request
Feb 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit proposal is operational for the purpose of the issue #2.
However, it leads me to the following analysis: Backuppc proposes a default configuration in a server, thar can be overrride, host per host, parameterper parameter, for different clients. The present proposal leads me to override two (more) values (
$Conf{RsyncClientCmd}and$Conf{RsyncClientRestoreCmd}) for all the clients. And this can lead to a not so clean configuration of the server.Maybe we should manage flags to say to the role when we want to override these values.