-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements and server role alignement #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading Readme.md...
Behaviour of scripts and db backups are different for mysql and pgsql. Particularly, for MySQL you must add yourself the scripts, por instance pre_dump.sh and post_dump.sh that do the job of dumping databases, while for PostgreSQL these scripts are built form templates (and they dump only a database).
Can't we make the role build these scripts from templates for Mysql?
Certainly the present behaviour to automate databases backups, limited and different for mysql and pgsql, is not very satisfactory. But this was not in the scope of this refactor and enhancement, which was to complete backuppc config, and clearly separate server and client roles. |
Sister backuppc_server role has evolvedfor a better management of all BackupPC parameters, particularly the description of shares backed up and inclusion/exclusion options.
Morover, it seemed more logical to adopt a single uniform syntax for name variables in backuppc config.pl file.
Finally, an idea that emerged documenting v2.1.X version was developed:no more
backuppc_scripts
flag, scripts are used when paths to files are defined. (Changes quite some code in therole, however)