This repository has been archived by the owner on Dec 27, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature issue5 - new set of templates, strict authoritative NS #6
base: main
Are you sure you want to change the base?
Feature issue5 - new set of templates, strict authoritative NS #6
Changes from 12 commits
ca1c663
38b48c6
64c2c1c
14d9e17
7b61f88
5f9d1c8
dddd215
c94073f
3d958f3
9e4c4f4
01fca78
1467fd2
6828f69
ca8bf80
b0aba0f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bind9_notify_explicit
is a boolean that sets a forced value, not a default value as many other global variables. It must be documented for the default template. I don't understand the reason of this behavior, so in other templates we may change it, to manage a default value and not a forced value, with abind9_notify
, eventually distinguishing masters and slaves.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the order filters are applied: What about if
zone.notify
is set toexplicit
? I guess the value will fall toyes
. the ternary should apply only if something clearlytrue
orfalse
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In any case, before proposing the PR I will bring back the default templates to their previous content.