-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CURA-8415 Update installers and added self-hosted installer #16516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to CURA-10855
If we ever need to start from scratch, temporarily remove `&& inputs.runner != 'self-hosted'` Contributes to CURA-8415
This reverts commit bcdd7c9.
Contributes to CURA-8415
Contributes to CURA-8415
Why should we build the installer twice? Contributes to CURA-8415
Contributes to CURA-8415
Contributes to CURA-8415
Contributes to CURA-8415
Contributes to CURA-8415
Contributes to CURA-8415
Contributes to CURA-8415
Contributes to CURA-8415
Contributes to CURA-8415
# Conflicts: # .github/workflows/macos.yml
Contributes to CURA-8415
Contributes to CURA-8415
Contributes to CURA-8415
Contributes to CURA-8415
Contributes to CURA-8415
Contributes to CURA-8415
Contributes to CURA-8415
Contributes to CURA-8415
Contributes to CURA-8415
#11841 (comment) Contributes to CURA-8415 and CURA-10855
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The installer workflows have been seperated in OS specific workflows, all with the same inputs. They can be called with dispatch (UI) or from another workflow.
For getting the Mac binaries build with M1 support, an Macbook M1 has been converted to a self-hosted GH runner. See internal confluence documentation, regarding installed tooling, security practices and network logistics.
We support both msi and exe installers for Windows and pkg and dmg for Mac. These are now created in a single job, sequentially. Parallelizing the creation and signing these between runners/jobs had a negligible gain but introduced a lot of complexity. Since it is very likely that we will drop support for the exe and dmg I decided to keep this as is and not put any more effort in it. Also because single quick OS installers can be requested by executing the individual workflow.
If the "All Installer" workflow is run it will create the following artifacts:
Each OS run will also show a summary of al conan and pip managed dependencies.
The https://github.com/Ultimaker/conan-config now has branches in the form of
runner/<runner.os>/<runner.arch>
to allow for runner specific overrides in the conan-config without polluting themaster
branch for all (community-)devs and other runners. These are a subset of the master branch config and will be appended on.The MacOS builds should be backward compatible, due to the simple usage of MacOS 12 which somehow still results in unfindable
coroutine
headers as they are still located inexperimental
. This commit should fix that: Ultimaker/CuraEngine@3ac71c0If we need to upgrade to MacOS 13 in order to use newer XCode (with full support for C++20/23) setting the following env variables should still ensure backward compatibility (atleast for the Python interp) #11841 (comment) . To minimize possible side-effects they're only set for the MacOS runners (see earlier comment for runner specific configurations)
Fixes #13135
Fixes #15833
Fixes #11841
An example run can be seen here: https://github.com/Ultimaker/Cura/actions/runs/5912156075