Fix mac Builds #18188
Merged
Fix mac Builds #18188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # conanfile.py
Due to some breaking changes in pyinstaller upgrade, add option to use old packaging pyinstaller/pyinstaller#7713 CURA-11483
casperlamboo
force-pushed
the
CURA-11483
branch
from
43273d3 to
54d6315
Compare
wawanbreton
reviewed
Feb 6, 2024
wawanbreton
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the pyqt 6.6 upgrade the mac builds were failing. Main fix was to upgrade pyinstaller (which allowed us to remove a whole lot of ugly ductyping).
In the new packaged app the file structure is a bit different for mac, so had to change some paths.
Also see Uranum PR: https://github.com/Ultimaker/Uranium/pull/936/files
CURA-11483