Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method(s) updates for 5.9 #19691

Merged
merged 34 commits into from
Oct 4, 2024
Merged

Method(s) updates for 5.9 #19691

merged 34 commits into from
Oct 4, 2024

Conversation

alanbjorklund
Copy link
Contributor

Method printers: Adding new materials (Tough PLA, PETG, NylonCF, ABS) and updated profiles for 5.9
PP-511

Added lots of updates for method printers including:

-ABS 175
-Nylon CF 175
-PETG 175
-Tough PLA 175
-preliminary settings for Labs materials (stored in generic files for now)
-updates to default infill strategy (matching CloudPrint)

updates to roof layer order and thickness
standardized soluble support values
standardized soluble raft values
added many max value / min value warnings to method def json (less yellow values in UI)
updated Method(s) build volume to match CloudPrint
added logic to extend X volume when the right extruder is disabled
adjust first layer settings when raft is not selected
enable prime tower when 2 extruders are active
use soluble raft when support is disabled and 2 extruders are active
hide parameters to select first layer extruder (toolpath always starts with the left extruder)
never use interleaved prime tower for Method printers
hide raft jerk & accel parameters

How Has This Been Tested?

Copied new files into an internal Cura build (sep19) then sliced and / or printed dozens of tests.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/7)

resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (2/7)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (3/7)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (4/7)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (5/7)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (6/7)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (7/7)

alanbjorklund and others added 2 commits September 27, 2024 14:25
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
alanbjorklund and others added 7 commits September 27, 2024 14:27
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

alanbjorklund and others added 2 commits September 27, 2024 15:09
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

@@ -16,7 +16,7 @@
},
"machine_extruder_cooling_fan_number": { "default_value": 0 },
"machine_extruder_end_code": { "default_value": "M106 P{extruder_nr} S1.0\nG91\nG0 Z0.4 F600\nG90\nG0 X{prime_tower_position_x - prime_tower_size/2} Y{prime_tower_position_y + prime_tower_size/2} F6000" },
"machine_extruder_start_code": { "default_value": "G0 X{prime_tower_position_x - prime_tower_size/2} Y{prime_tower_position_y + prime_tower_size/2} F6000\nM104 S{material_print_temperature}\nG4 S5\nG91\nG0 Z-0.4 F600\nG90\nM107 P{(extruder_nr+1)%2}\nM106 P{extruder_nr} S{cool_fan_speed_0/100}" },
"machine_extruder_start_code": { "default_value": "G0 X{prime_tower_position_x - prime_tower_size/2} Y{prime_tower_position_y + prime_tower_size/2} F6000\nM104 S{material_print_temperature}\nG4 S5\nG91\nG0 Z-0.4 F600\nG90\nM107 P{(extruder_nr+1)%2}\nM106 P{extruder_nr} S{(layer_z > 1 ? cool_fan_speed : cool_fan_speed_0)}" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fan speeds need to be divided by 100. The Method has a range from 0..1 and these parameters have a range from 0..100.

@HellAholic HellAholic merged commit 92893b9 into main Oct 4, 2024
12 checks passed
@HellAholic HellAholic deleted the PP-511-Method-5-9-Rebased branch October 4, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants