-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Method(s) updates for 5.9 #19691
Method(s) updates for 5.9 #19691
Conversation
… and updated profiles for 5.9 PP-511
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/7)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (2/7)
resources/intent/ultimaker_method/um_method_1a_um-pla-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_method/um_method_1a_um-tough-pla-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_method/um_method_1c_um-nylon-cf-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_method/um_method_1c_um-nylon12-cf-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_method/um_method_1c_um-pla-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_method/um_method_1c_um-tough-pla-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_method/um_method_labs_um-nylon-cf-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_method/um_method_labs_um-nylon12-cf-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_method/um_method_labs_um-pla-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (3/7)
resources/intent/ultimaker_method/um_method_labs_um-tough-pla-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodx/um_methodx_1a_um-pla-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodx/um_methodx_1a_um-tough-pla-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodx/um_methodx_1c_um-abs-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodx/um_methodx_1c_um-abscf-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodx/um_methodx_1c_um-absr-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodx/um_methodx_1c_um-asa-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodx/um_methodx_1c_um-nylon-cf-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodx/um_methodx_1c_um-nylon12-cf-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodx/um_methodx_1c_um-pla-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (4/7)
resources/intent/ultimaker_methodx/um_methodx_1c_um-tough-pla-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodx/um_methodx_1xa_um-abs-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodx/um_methodx_1xa_um-absr-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodx/um_methodx_1xa_um-asa-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodx/um_methodx_labs_um-abs-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodx/um_methodx_labs_um-abscf-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodx/um_methodx_labs_um-absr-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodx/um_methodx_labs_um-asa-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodx/um_methodx_labs_um-nylon-cf-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodx/um_methodx_labs_um-nylon12-cf-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (5/7)
resources/intent/ultimaker_methodx/um_methodx_labs_um-pla-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodx/um_methodx_labs_um-tough-pla-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodxl/um_methodxl_1a_um-pla-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodxl/um_methodxl_1a_um-tough-pla-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodxl/um_methodxl_1c_um-abs-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodxl/um_methodxl_1c_um-abscf-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodxl/um_methodxl_1c_um-absr-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodxl/um_methodxl_1c_um-asa-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodxl/um_methodxl_1c_um-nylon-cf-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodxl/um_methodxl_1c_um-nylon12-cf-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (6/7)
resources/intent/ultimaker_methodxl/um_methodxl_1c_um-pla-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodxl/um_methodxl_1c_um-tough-pla-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodxl/um_methodxl_1xa_um-abs-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodxl/um_methodxl_1xa_um-absr-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodxl/um_methodxl_1xa_um-asa-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodxl/um_methodxl_labs_um-abs-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodxl/um_methodxl_labs_um-abscf-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodxl/um_methodxl_labs_um-absr-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodxl/um_methodxl_labs_um-asa-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodxl/um_methodxl_labs_um-nylon-cf-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (7/7)
resources/intent/ultimaker_methodxl/um_methodxl_labs_um-nylon12-cf-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodxl/um_methodxl_labs_um-pla-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
resources/intent/ultimaker_methodxl/um_methodxl_labs_um-tough-pla-175_0.2mm_solid.inst.cfg
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…from method base definition file PP-511
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
CURA-12165 This is required because methodxl definition inherits methodx, which has a defined plaftofm_offset.
…range stay within 0..1. PP-511
@@ -16,7 +16,7 @@ | |||
}, | |||
"machine_extruder_cooling_fan_number": { "default_value": 0 }, | |||
"machine_extruder_end_code": { "default_value": "M106 P{extruder_nr} S1.0\nG91\nG0 Z0.4 F600\nG90\nG0 X{prime_tower_position_x - prime_tower_size/2} Y{prime_tower_position_y + prime_tower_size/2} F6000" }, | |||
"machine_extruder_start_code": { "default_value": "G0 X{prime_tower_position_x - prime_tower_size/2} Y{prime_tower_position_y + prime_tower_size/2} F6000\nM104 S{material_print_temperature}\nG4 S5\nG91\nG0 Z-0.4 F600\nG90\nM107 P{(extruder_nr+1)%2}\nM106 P{extruder_nr} S{cool_fan_speed_0/100}" }, | |||
"machine_extruder_start_code": { "default_value": "G0 X{prime_tower_position_x - prime_tower_size/2} Y{prime_tower_position_y + prime_tower_size/2} F6000\nM104 S{material_print_temperature}\nG4 S5\nG91\nG0 Z-0.4 F600\nG90\nM107 P{(extruder_nr+1)%2}\nM106 P{extruder_nr} S{(layer_z > 1 ? cool_fan_speed : cool_fan_speed_0)}" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fan speeds need to be divided by 100. The Method has a range from 0..1 and these parameters have a range from 0..100.
Method printers: Adding new materials (Tough PLA, PETG, NylonCF, ABS) and updated profiles for 5.9
PP-511
Added lots of updates for method printers including:
-ABS 175
-Nylon CF 175
-PETG 175
-Tough PLA 175
-preliminary settings for Labs materials (stored in generic files for now)
-updates to default infill strategy (matching CloudPrint)
updates to roof layer order and thickness
standardized soluble support values
standardized soluble raft values
added many max value / min value warnings to method def json (less yellow values in UI)
updated Method(s) build volume to match CloudPrint
added logic to extend X volume when the right extruder is disabled
adjust first layer settings when raft is not selected
enable prime tower when 2 extruders are active
use soluble raft when support is disabled and 2 extruders are active
hide parameters to select first layer extruder (toolpath always starts with the left extruder)
never use interleaved prime tower for Method printers
hide raft jerk & accel parameters
How Has This Been Tested?
Copied new files into an internal Cura build (sep19) then sliced and / or printed dozens of tests.