Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the new cool_during_extruder_switch feature to switch the Metho… #19733

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

pkuiper-ultimaker
Copy link
Contributor

@pkuiper-ultimaker pkuiper-ultimaker commented Oct 10, 2024

The Method machines actively cool the nozzle at the end of a layer switch. Use the new cool_during_extruder_switch feature to enable this behavior and remove it from the start and end GCode template.

We also command the extruder to go to the standby temperature at the end of a layer to start cooling down. Lastly the heatup and 5 seconds wait has been removed from the start extruder GCode. This behavior is redundant and is already managed by the switch over logic.

PP-530

Test together with this Cura 5.9 test version that contains fixes to the cooling logic: https://github.com/Ultimaker/Cura/actions/runs/11254215837

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

Copy link
Contributor

@alanbjorklund alanbjorklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I printed a Method X slice, the fans behaved as expected.

Copy link
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !
In the future, could you consider making a base extruder definition for all Method printers, and inherit from it ? Their definition looks extremely similar. I don't see any inheriting extruder definition though, so maybe there is a reason for not doing it ?

@wawanbreton wawanbreton force-pushed the PP-530-Robust-switchover-fan-sequence branch from bf51e81 to 476ddf1 Compare October 14, 2024 09:27
@wawanbreton wawanbreton changed the base branch from main to 5.9 October 14, 2024 09:27
@wawanbreton
Copy link
Contributor

@pkuiper-ultimaker I rebased the changes on 5.9 branch. If you have future PRs, please don't forget to base them on 5.9

@pkuiper-ultimaker
Copy link
Contributor Author

Looks good ! In the future, could you consider making a base extruder definition for all Method printers, and inherit from it ? Their definition looks extremely similar. I don't see any inheriting extruder definition though, so maybe there is a reason for not doing it ?

I assumed that inheriting extruder ptofiles was not possible, because I have not seen examples. But perhaps it works. I will give it a try.

@HellAholic HellAholic merged commit af5baba into 5.9 Oct 16, 2024
13 checks passed
@HellAholic HellAholic deleted the PP-530-Robust-switchover-fan-sequence branch October 16, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants