Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURA-12195 add max limit to scarf settings #19783

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

wawanbreton
Copy link
Contributor

  • Add a warning when Scarf Seam Step Length is greater than Scarf Seam Length, which is not critical but does not really make sense
  • Enable "Scarf Seam Start Height" and "Scarf Seam Step Length" only when "Scarf Seam Length" is actually greater than 0, to emphasize the fact that a 0 distance means the feature disabled.

CURA-12195

@wawanbreton wawanbreton changed the base branch from main to 5.9 October 21, 2024 09:20
Copy link
Contributor

@HellAholic HellAholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HellAholic HellAholic merged commit d9cfd7f into 5.9 Oct 21, 2024
11 checks passed
@HellAholic HellAholic deleted the CURA-12195_Add-max-limit-to-scarf-settings branch October 21, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants