Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CURA-12362] Cheetah flavor #2198

Merged
merged 5 commits into from
Jan 23, 2025
Merged

[CURA-12362] Cheetah flavor #2198

merged 5 commits into from
Jan 23, 2025

Conversation

Frederic98
Copy link
Contributor

Description

This PR adds the Cheetah GCode flavor

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Sliced a file

Test Configuration:

  • Operating System:
    Ubuntu 24.04

Checklist:

  • My code follows the style guidelines of this project as described in UltiMaker Meta
  • I have read the Contribution guide
  • I have commented my code, particularly in hard-to-understand areas
  • I have uploaded any files required to test this change

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 20, 2025 •
edited
Loading

Test Results

27 tests  ±0   27 ✅ ±0   5s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 518d620. ± Comparison against base commit a7e6fa0.

♻️ This comment has been updated with latest results.

rburema
rburema approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@rburema rburema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@HellAholic HellAholic merged commit 35a8c58 into main Jan 23, 2025
22 of 23 checks passed
@HellAholic HellAholic deleted the CURA-12362_Cheetah_flavor branch January 23, 2025 11:17
@fieldOfView
Copy link
Collaborator

Couldn't (shouldn't?) this have been done with a machine setting instead?

@rburema
Copy link
Member

rburema commented Jan 28, 2025

@fieldOfView It's M215, not M205, so these aren't just value changes, it actually means something different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rburema rburema rburema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Frederic98 @fieldOfView @rburema @HellAholic