Clean up bot LUT

[casperlamboo]

We had a lot of Look up Tables scattered around in the cura repository. This can be solved by adding a bot_id entry to metadata of the various makerbot extruders/materials/definitions

[pkuiper-ultimaker]

The use of a <bot_id> in the fdmmaterial file feels like a hack.

[pkuiper-ultimaker]

A material is not a bot_id. This is very confusing, I also do not know why you need it. The GUID uniquely identifies the material to do a look up in a database.
Also when you would do this you also need to change the the fdmmaterial.xsd other wise digital factory throw an error.

[casperlamboo]

A bot_id is not a material, but I do consider it to be a property of the material. And that is what metadata is; it contains useful properties regarding the material.

The GUID uniquely identifies the material to do a look up in a database.

According to this logic we can also remove for instance the color attribute from the metadata; as each guid uniquely identifies a color just lookup the color each time you try to retrieve it.

[casperlamboo]

@pkuiper-ultimaker you should see the PR in combination with this PR: Ultimaker/Cura#17422

By adding the bot type to the metadata we can completely remove all look up tables from the .makerbot writer, which I really like. And I do consider the "bot type" as it is known to the printer/digital factory to be an attribute of the materials, extruder, printer definition, and I do consider the metadata a quite logical place to add.

Why would you consider it to be a hack?

[pkuiper-ultimaker]

Hi Casper, I like the removal of the teanslation tables (maintenance nightmare) and attach the data once at the level it belongs. However, the naming is confusing when you open the files. Perhaps call them bot_machine_id, bot_extruder_id and bot_material_id to at least make clear for which type the id is meant.

…

On Sat, 25 Nov 2023 at 01:33, Casper Lamboo ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In generic_abs_175.xml.fdm_material <#273 (comment)> : > @@ -11,6 +11,7 @@ Generic ABS 1.75mm profile. The data in this file may not be correct for your sp </name> <GUID>2780b345-577b-4a24-a2c5-12e6aad3e690</GUID> <version>11</version> + <bot_id>abs</bot_id> A bot_id *is* not a material, but I do consider it to be a property of the material. And that is what metadata is; it contains useful properties regarding the material. The GUID uniquely identifies the material to do a look up in a database. According to this logic we can also remove for instance the color attribute from the metadata; as each guid uniquely identifies a color just lookup the color each time you try to retrieve it. — Reply to this email directly, view it on GitHub <#273 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALENIA2T2SNYPBCC4EZ6Q63YGE4GRAVCNFSM6AAAAAA7ZJ2YNKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONBYGUYTMMBRHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- NOTICE: This email may contain information that is confidential or attorney-client privileged and may constitute inside information or trade secrets. The contents of this email are intended only for the recipient(s) listed above. If you are not the intended recipient, you are directed not to read, disclose, distribute or otherwise use this transmission. If you have received this email in error, please notify the sender immediately and delete the transmission. Delivery of this message is not intended to waive any applicable privileges.

[jellespijker]

LGTM

[jellespijker]

Ensure the CI/CD for our firmware friends can handle the change

Changes are applied