This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
Bugfix: c2usb deinit assert #248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benedekkupper
force-pushed
the
bugfix/c2usb-deinit-assert
branch
from
f84454c to
459a1bb
Compare
|
According to my testing, Zephyr doesn't crash this way. However, the USB connection doesn't recover when disconnecting Bluetooth: The USB mouse interface sometimes recovers, but the USB keyboard interface never recovers. In its current state, the bug that this PR introduces outweighs the fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix this issue:
UltimateHackingKeyboard/firmware#999
This is a temporary bugfix, the final fix will need a bigger overhaul of how we destroy the USB connection when the BLE HID connection is established (it's a multithreading issue).