Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the default num_workers is set to
2*gpus
. However, on Windows there is an issue with this default behavior (but only whengpus>0
).Massive shout-out to @awaelchli who helped in pin-pointing the issue and confirming that the issue cannot be inherently contributed to PyTorch Lightning but that instead this is a consequence of how
self
is passed to the data loader, which will then be parallellized but spawning new processes is different on Windows and Linux, which lead to the issues present here. This issue is therefore very similar to other common errors that are often encountered, related the PyTorch DataLoader.num_workers=0
is the best bet to avoid issues on Windows.So this PR sets
num_workers=0
if we're on Windows, by default. It will also throw a warning to the user when they have manually set num_workers to a higher number when using the GPU and when on Windows, as that is the use-case that will not work.closes #190